Skip to content

Verify Samples in Build #10031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2021
Merged

Verify Samples in Build #10031

merged 1 commit into from
Jul 27, 2021

Conversation

@marcusdacoregio
Copy link
Contributor

@marcusdacoregio marcusdacoregio commented Jun 30, 2021 •
edited
Loading

Creates a new Gradle task named checkSamples which clones and performs a ./gradlew check on the Samples project.
Adds a new job in the CI workflow which runs the new checkSamples task.

Closes gh-9846

@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue in: build An issue in the build type: enhancement A general enhancement labels Jun 30, 2021
@marcusdacoregio marcusdacoregio requested a review from jzheaux June 30, 2021 16:12
@marcusdacoregio marcusdacoregio self-assigned this Jun 30, 2021
@marcusdacoregio marcusdacoregio marked this pull request as ready for review July 1, 2021 12:00
jzheaux
jzheaux requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @marcusdacoregio! I've left some feedback inline.

@marcusdacoregio marcusdacoregio force-pushed the gh-9846 branch 3 times, most recently from f82aa0e to 3ca272f Compare July 5, 2021 13:11
@marcusdacoregio
Copy link
Contributor Author

I've updated the PR with your suggestions @jzheaux. Can you review it again? Thanks!

@marcusdacoregio marcusdacoregio requested a review from jzheaux July 5, 2021 13:31
jzheaux
jzheaux requested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcusdacoregio! I've left some feedback inline.

@marcusdacoregio marcusdacoregio requested a review from jzheaux July 8, 2021 11:14
@marcusdacoregio
Copy link
Contributor Author

Thanks for the review @jzheaux, I've updated the PR based on your suggestions.

@marcusdacoregio marcusdacoregio added this to the 5.6.0-M2 milestone Jul 19, 2021
jzheaux
jzheaux requested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @marcusdacoregio! I've left my remaining feedback inline. Once those are addressed feel free to merge.

@marcusdacoregio marcusdacoregio force-pushed the gh-9846 branch 2 times, most recently from 64a0e11 to 4878239 Compare July 27, 2021 14:29
@marcusdacoregio marcusdacoregio merged commit c562d56 into spring-projects:main Jul 27, 2021
@marcusdacoregio marcusdacoregio deleted the gh-9846 branch July 27, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzheaux jzheaux jzheaux requested changes

Assignees

@marcusdacoregio marcusdacoregio

Labels

in: build An issue in the build status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Milestone

5.6.0-M2

Development

Successfully merging this pull request may close these issues.

Verify Samples in Build

2 participants

@marcusdacoregio @jzheaux